Skip to content

Require lib-innerbrowser 2.0 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Naktibalda
Copy link
Member

module-phpbrowser 2.0 is incompatible with lib-innerbrowser 1.0 because property types don't match

See Codeception/Codeception#6293

module-phpbrowser 2.0 is incompatible with lib-innerbrowser 1.0 because property types don't match
@TavoNiievez
Copy link
Member

TavoNiievez commented Dec 17, 2021

@ThomasLandauer made me realize this.

There are a few more repositories that I would like to update the dependencies on.
It had not raised these PRs because it could not launch versions of lib-asserts, required by module-asserts and so on.
Those dependencies in Codeception need to be updated as well because 2.x versions are not allowed yet,

I'm sorry I was late with this, and thanks.

Copy link
Member

@TavoNiievez TavoNiievez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codeception/module-rest must also be updated.

@Naktibalda
Copy link
Member Author

codeception/module-rest must also be updated.

Why? It doesn't extend InnerBrowser.

@Naktibalda Naktibalda deleted the 2.0-require-lib-innerbroser-2.0 branch December 17, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants